| Anonymous | Login | Signup for a new account | 05-25-2013 16:20 MDT |  |
| All Projects | HeroForge | ModernForge | MonsterForge | SpellForge |
| Main | My View | View Issues | Change Log | Roadmap |
| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update | |
| 0000321 | HeroForge | Optimization | public | 04-07-2010 04:49 | 06-05-2010 16:45 | |
| Reporter | Christophe Kowalski | |||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | |
| Status | closed | Resolution | fixed | |||
| Platform | OS | OS Version | ||||
| Product Version | 6.1.0.0 | |||||
| Target Version | 6.1.0.1 | Fixed in Version | 6.1.0.1 | |||
| Summary | 0000321: Version control, Release Notes and Change Log | |||||
| Description | In the current setup, many adjustments are required for a new release, including to the code. The following proposes a single source of data for version, relnotes and changelog. - a version data table - remove reference to a specific version on buttons (option sheet) but display sheet version in a cell instead. - use a named range for the target version on mantis - remove hardcoded relnotes and refer to the wiki page instead. - restrict the version compatibility check done by import to the major, source, and bugfix part of version number. Minor releases should always ensure backward compatibility of the character sheets. | |||||
| Additional Information | Insert a new sheet OptionsInfo (named wsOptionsInfo) hosting the version table and related data (later on, it should also host sourcebooks, worksheets table, and options) Add the version table (see attached doc for full description) and related variables. Remove Version and VersionNumber from the Options sheet. Insert a cell on Options ="HeroForge (D&D 3.5) " & Version and remove hard-coded references from the relnotes and changelog buttons. Code changes: create Module "Options" move sub DisplayChangeLog from ChangeLogButton to Options in sub DisplayChangeLog , replaced < Address:="http://heroforge.redmop.com/mantis/changelog_page.php?version_id=9", [^] _ with > Address:=http://heroforge.redmop.com/mantis/changelog_page.php?version_id= [^] & Range("VersionLog").Value, _ removed module ChangeLogButton removed Module DisplayNotes insert sub Sub DisplayNotes() ActiveWorkbook.FollowHyperlink _ Address:="http://heroforge.redmop.com/index.php?title=FAQs#What_sourcebooks_does_it_currently_support.3F", [^] _ NewWindow:=True End Sub For compatibility purposes: In PushToExportSheet 'Version Number Range("ExportVersion").Value = Range("Version").Value Range("VersionExport").Value = Range("Version").Value (on the long run, ExportVersion should go and be replaced with VersionExport, ReleaseDate =unnamed cell B2 on exportsheet= should be replaced with VersionDate) In Export initialFileToSave = Range("CharacterName").Value & " (Lvl " & Range("CharLvl").Value & ")_" & Range("Version").Value & " (D&D 3.5).hfg" In Import The following check should be done BEFORE loading custom sheets… and should be restricted to major/source/bug fix (minor should remain compatible). Replace: If Range("A2").Value = ThisWorkbook.Worksheets("Options").Range("Version") Then with Dim ImportVersion As String Dim HFVersion As String ImportVersion = Range("A2").Value HFVersion = Range("Version").Value 'For backward compatibility only) If Left(ImportVersion, 1) <> "v" Then ImportVersion = "v" & ImportVersion End If If Left(ImportVersion, 6) <> Left(HFVersion, 6) Then (this will only work with single digits in the components of version number. … Range("VersionExport").Value = Range("ExportVersion").Value | |||||
| Tags | No tags attached. | |||||
| Attached Files |  Version Control.doc (36,352 bytes) 04-07-2010 04:49 | |||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0000909) Christophe Kowalski (developer) 04-07-2010 04:50 |
Comments are welcome. |
|
(0000912) Shawn Perry (administrator) 04-07-2010 09:49 |
That all seems like good stuff. |
|
(0001016) Christophe Kowalski (developer) 04-16-2010 18:24 |
Implemented as described. Full compatibility w 6.1.0.0. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 04-07-2010 04:49 | Christophe Kowalski | New Issue | |
| 04-07-2010 04:49 | Christophe Kowalski | Status | new => assigned |
| 04-07-2010 04:49 | Christophe Kowalski | Assigned To | => Christophe Kowalski |
| 04-07-2010 04:49 | Christophe Kowalski | File Added: Version Control.doc | |
| 04-07-2010 04:50 | Christophe Kowalski | Note Added: 0000909 | |
| 04-07-2010 04:50 | Christophe Kowalski | Status | assigned => feedback |
| 04-07-2010 09:49 | Shawn Perry | Note Added: 0000912 | |
| 04-16-2010 15:19 | Christophe Kowalski | Description Updated | View Revisions |
| 04-16-2010 15:19 | Christophe Kowalski | Additional Information Updated | View Revisions |
| 04-16-2010 18:24 | Christophe Kowalski | Note Added: 0001016 | |
| 04-16-2010 18:24 | Christophe Kowalski | Status | feedback => assigned |
| 04-16-2010 18:24 | Christophe Kowalski | Status | assigned => resolved |
| 04-16-2010 18:24 | Christophe Kowalski | Resolution | open => fixed |
| 04-16-2010 18:24 | Christophe Kowalski | Fixed in Version | => 6.1.0.1 |
| 04-16-2010 18:24 | Christophe Kowalski | Target Version | => 6.1.0.1 |
| 06-05-2010 16:45 | Yonner | Status | resolved => closed |
|
Issue History |
| MantisBT 1.2.0[^] HeroForge and the HeroForge Logo are Trademarks of HeroForge Software, LLC - Copyright 2008 - 2009 HeroForge Software, LLC. All rights reserved. MantisBT - Copyright © 2000 - 2010 MantisBT Group |
 |